action/check-naming
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(check-naming): reject media fallback provenance
test / test (pull_request) Successful in 9s
Details

Browse Source 
Authored-By: Codex (GPT-5) <noreply@openai.com>
This commit is contained in:
architect
2026-08-27 18:02:22 +00:00
parent 29c34f1527
commit 4b91be68a2
3 changed files with 31 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
check.sh
+21 -13
View File
@@ -41,9 +41,9 @@ elif ! RENDERED_BODY=$(printf '%s' "${BODY}" |
FAILED=1 FAILED=1
fi fi
# A collapsed disclosure is valid supporting content, but provenance inside one # Remove rendered subtrees that aren't visible by default. An open disclosure
# is not visible by default. Remove only collapsed details subtrees; an open # remains visible unless one of its ancestors is hidden; media fallback content
# disclosure remains visible unless one of its ancestors is collapsed. # is hidden when the browser supports the containing element.
VISIBLE_BODY=$(printf '%s\n' "${RENDERED_BODY}" | VISIBLE_BODY=$(printf '%s\n' "${RENDERED_BODY}" |
awk ' awk '
{ {
@@ -54,20 +54,28 @@ VISIBLE_BODY=$(printf '%s\n' "${RENDERED_BODY}" |
tag=tag char tag=tag char
if (char == ">") { if (char == ">") {
lower=tolower(tag) lower=tolower(tag)
if (lower ~ /^<details([[:space:]>])/) { opening=lower
sub(/^</, "", opening)
sub(/[[:space:]>].*$/, "", opening)
closing=lower
sub(/^<\//, "", closing)
sub(/[[:space:]>].*$/, "", closing)
if (opening ~ /^(details|audio|video|canvas|object)$/) {
attributes=lower attributes=lower
gsub(/"[^"]*"/, "", attributes) gsub(/"[^"]*"/, "", attributes)
parent_hidden=(details_depth > 0 && hidden[details_depth]) parent_hidden=(container_depth > 0 && hidden[container_depth])
details_depth++ container_depth++
hidden[details_depth]=(parent_hidden || attributes !~ /[[:space:]]open([[:space:]=>]|$)/) container[container_depth]=opening
hidden[container_depth]=(parent_hidden || opening != "details" || attributes !~ /[[:space:]]open([[:space:]=>]|$)/)
} }
else if (lower ~ /^<\/details([[:space:]>])/) { else if (closing ~ /^(details|audio|video|canvas|object)$/) {
if (details_depth > 0) { if (container_depth > 0 && container[container_depth] == closing) {
delete hidden[details_depth] delete container[container_depth]
details_depth-- delete hidden[container_depth]
container_depth--
} }
} }
else if (!hidden[details_depth]) printf "%s", tag else if (!hidden[container_depth]) printf "%s", tag
in_tag=0 in_tag=0
tag="" tag=""
} }
@@ -76,7 +84,7 @@ VISIBLE_BODY=$(printf '%s\n' "${RENDERED_BODY}" |
in_tag=1 in_tag=1
tag=char tag=char
} }
else if (!hidden[details_depth]) printf "%s", char else if (!hidden[container_depth]) printf "%s", char
} }
} }
') ')
tests/bin/curl
+4
View File
@@ -68,6 +68,10 @@ printf '%s\n' "${PR_BODY}" | awk '
print line print line
next next
} }
if (lower ~ /^[ ]{0,3}<\/?(audio|video|canvas|object)([[:blank:]>])/) {
print line
next
}
if (line ~ /^## Tracking[[:space:]]*$/) print "<h2>Tracking</h2>" if (line ~ /^## Tracking[[:space:]]*$/) print "<h2>Tracking</h2>"
else if (line ~ /^## Attribution[[:space:]]*$/) print "<h2>Attribution</h2>" else if (line ~ /^## Attribution[[:space:]]*$/) print "<h2>Attribution</h2>"
else if (line ~ /^- Fixes[[:space:]]/) print "<li>" substr(line, 3) "</li>" else if (line ~ /^- Fixes[[:space:]]/) print "<li>" substr(line, 3) "</li>"
tests/run
+6
View File
@@ -188,6 +188,12 @@ check_contract "open details inside collapsed details remain hidden" \
check_contract "open text in another details attribute remains collapsed" \ check_contract "open text in another details attribute remains collapsed" \
$'<details title="x open y"><summary>Release notes</summary>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</details>' \ $'<details title="x open y"><summary>Release notes</summary>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</details>' \
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section" "$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
check_contract "video fallback cannot hide provenance" \
$'<video controls>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</video>' \
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
check_contract "audio fallback cannot hide provenance" \
$'<audio controls>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</audio>' \
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
check_contract_pass "unrelated collapsed details remain available" \ check_contract_pass "unrelated collapsed details remain available" \
$'<details><summary>Logs</summary>\n\nSupporting output\n</details>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \ $'<details><summary>Logs</summary>\n\nSupporting output\n</details>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
"$BASE" "$GOOD_HEAD" "$BASE" "$GOOD_HEAD"