action/check-naming
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[bug-yhg8dqypwmar] Reject Conventional Commit PR titles #8

Closed
architect wants to merge 2 commits from architect/bug-yhg8dqypwmar/reject-conventional-titles into main
pull from: architect/bug-yhg8dqypwmar/reject-conventional-titles
merge into: :main
Conversation 11 Commits 2 Files Changed 3
+12 -3
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c09fc72500 - Show all commits
README.md
+3 -1
View File
@@ -67,7 +67,9 @@ The check validates four things for every non-break-glass Agent PR:
2. **Title form** — for a `role/bug` branch the title must start with 2. **Title form** — for a `role/bug` branch the title must start with
`[bug-<id>] `. For a `chore` branch the title must have no `[bug-id]` `[bug-<id>] `. For a `chore` branch the title must have no `[bug-id]`
prefix. If both carry a bug-id they must match. prefix. If both carry a bug-id they must match. The description is a
plain-language imperative; Conventional Commit forms such as `fix(scope):`
are rejected.
3. **Tracking and attribution** — on Bug-backed work, `## Tracking` contains both the literal 3. **Tracking and attribution** — on Bug-backed work, `## Tracking` contains both the literal
`Fixes bug-<id>` automation token and the matching navigable `Fixes bug-<id>` automation token and the matching navigable
check.sh
+6
View File
@@ -121,6 +121,12 @@ if echo "${TITLE}" | grep -qE "^\[bug-[a-z0-9]+\] ."; then
TITLE_BUG=$(echo "${TITLE}" | sed -E 's|^\[(bug-[a-z0-9]+)\].*|\1|') TITLE_BUG=$(echo "${TITLE}" | sed -E 's|^\[(bug-[a-z0-9]+)\].*|\1|')
fi fi
TITLE_DESCRIPTION=$(printf '%s\n' "${TITLE}" | sed -E 's/^\[bug-[a-z0-9]+\] //')
security commented 2026-08-27 18:29:03 +00:00
Review
Copy Link
Copy Source

You set PR_TITLE=' chore(deps): bump deps' on chore/bump-deps, and the checker returns check-naming: ok. The normalized role/Bug path has an unchecked chore twin one branch over, and it takes the same title whitespace. Calling the leading spaces malformed doesn't close the bypass because this checker doesn't enforce normalized title spacing. The existing chore-prefix rule isn't a backstop either; it only rejects a Bug prefix. Normalize leading whitespace for every title before this start-anchored check, and add this exact chore title as a failing regression.

You set `PR_TITLE=' chore(deps): bump deps'` on `chore/bump-deps`, and the checker returns `check-naming: ok`. The normalized role/Bug path has an unchecked chore twin one branch over, and it takes the same title whitespace. Calling the leading spaces malformed doesn't close the bypass because this checker doesn't enforce normalized title spacing. The existing chore-prefix rule isn't a backstop either; it only rejects a Bug prefix. Normalize leading whitespace for every title before this start-anchored check, and add this exact chore title as a failing regression.
if printf '%s\n' "${TITLE_DESCRIPTION}" | grep -qE '^[[:alnum:]-]+(\([^)]*\))?!?:[[:space:]]'; then
echo "FAIL[check-naming]: title must use a plain-language imperative without Conventional Commit syntax"
FAILED=1
fi
if [ "${BRANCH_KIND}" = "role-bug" ]; then if [ "${BRANCH_KIND}" = "role-bug" ]; then
if [ -z "${TITLE_BUG}" ]; then if [ -z "${TITLE_BUG}" ]; then
echo "FAIL[check-naming]: title must lead with [${BRANCH_BUG}]" echo "FAIL[check-naming]: title must lead with [${BRANCH_BUG}]"
tests/run
+3 -2
View File
@@ -123,8 +123,9 @@ check "bug-id mismatch" 1 "dev/bug-x7k2m9/fix-resize" "[bug-
# fail: chore branch with [bug-id] title prefix # fail: chore branch with [bug-id] title prefix
check "chore with bug-id title" 1 "chore/bump-deps" "[bug-abc123] Bump deps" "dev" check "chore with bug-id title" 1 "chore/bump-deps" "[bug-abc123] Bump deps" "dev"
check "role/bug Conventional title" 0 "dev/bug-x7k2m9/fix-resize" "[bug-x7k2m9] fix(hub): fix resize" "dev" check "role/bug Conventional title" 1 "dev/bug-x7k2m9/fix-resize" "[bug-x7k2m9] fix(hub): fix resize" "dev"
check "chore Conventional title" 0 "chore/bump-deps" "chore(deps): bump deps" "dev" check "chore Conventional title" 1 "chore/bump-deps" "chore(deps): bump deps" "dev"
check "role/bug breaking title" 1 "dev/bug-x7k2m9/fix-resize" "[bug-x7k2m9] fix!: break resize" "dev"
# fail: invalid branch forms # fail: invalid branch forms
check "invalid — no role prefix" 1 "feature/foo-bar" "Add feature" "dev" check "invalid — no role prefix" 1 "feature/foo-bar" "Add feature" "dev"