Authored-By: OpenAI (GPT-5) <noreply@openai.com>
This commit is contained in:
+31
-1
@@ -104,6 +104,26 @@ def _strings(value, label):
|
||||
return values
|
||||
|
||||
|
||||
def _cors_origins(value, label):
|
||||
origins = _strings(value or [], label)
|
||||
if len(origins) != len(set(origins)):
|
||||
raise ConfigError(f"{label} must not contain duplicates")
|
||||
for origin in origins:
|
||||
if origin == "*":
|
||||
continue
|
||||
parsed = urlparse(origin)
|
||||
try:
|
||||
port = parsed.port
|
||||
except ValueError:
|
||||
port = None
|
||||
if parsed.scheme != "https" or not parsed.hostname or parsed.path or parsed.params or (
|
||||
parsed.query or parsed.fragment or parsed.username or parsed.password
|
||||
or (":" in parsed.netloc and port is None and not parsed.netloc.endswith("]"))
|
||||
):
|
||||
raise ConfigError(f"{label} must contain '*' or HTTPS origins")
|
||||
return origins
|
||||
|
||||
|
||||
def _hostname(value, label):
|
||||
if not isinstance(value, str) or len(value) > 253 or value.endswith("."):
|
||||
raise ConfigError(f"{label} must be a lowercase DNS hostname without a trailing dot")
|
||||
@@ -215,6 +235,7 @@ def _legacy_config(raw, site_name):
|
||||
"website_authority": "garage-s3.storage.svc.k8s.sjc001.fritzlab.net",
|
||||
"credentials": {"access_key_env": "AWS_ACCESS_KEY_ID", "secret_key_env": "AWS_SECRET_ACCESS_KEY"},
|
||||
"cache_rules": [{"path": "", "cache_control": DEFAULT_CACHE_CONTROL}],
|
||||
"cors_origins": None,
|
||||
}
|
||||
return {
|
||||
"version": 1,
|
||||
@@ -234,7 +255,11 @@ def _legacy_config(raw, site_name):
|
||||
def _artifact(item, index):
|
||||
label = f"artifacts[{index}]"
|
||||
item = _mapping(item, label)
|
||||
_known_keys(item, {"name", "type", "content_dir", "tidy", "excludes", "publish", "cache"}, label)
|
||||
_known_keys(
|
||||
item,
|
||||
{"name", "type", "content_dir", "tidy", "excludes", "publish", "cache", "cors_origins"},
|
||||
label,
|
||||
)
|
||||
name = item.get("name")
|
||||
if not isinstance(name, str) or not NAME_RE.fullmatch(name):
|
||||
raise ConfigError(f"{label}.name must be a DNS label")
|
||||
@@ -303,6 +328,7 @@ def _artifact(item, index):
|
||||
"website_authority": authority,
|
||||
"credentials": normalized_credentials,
|
||||
"cache_rules": cache_rules,
|
||||
"cors_origins": _cors_origins(item.get("cors_origins"), f"{label}.cors_origins"),
|
||||
}
|
||||
|
||||
|
||||
@@ -389,6 +415,10 @@ def _validate_multi(cfg):
|
||||
raise ConfigError(f"protected route {route['name']} cannot use shared-cache max-age")
|
||||
if route["access"] == "public" and "private" in directives:
|
||||
raise ConfigError(f"public route {route['name']} cannot use private cache policy")
|
||||
if route["access"] == "protected" and "*" in artifact["cors_origins"]:
|
||||
raise ConfigError(
|
||||
f"protected route {route['name']} cannot allow wildcard CORS"
|
||||
)
|
||||
root = next(route for route in routes if route["path"] == "/")
|
||||
if any(route["access"] == "protected" for route in routes) and root["access"] == "public":
|
||||
raise ConfigError("a public '/' catch-all would expose unmatched protected content")
|
||||
|
||||
Reference in New Issue
Block a user