[bug-hvhthrwf9ry8] fix(check-naming): print corrected title on missing-prefix failure #2

2026-08-25T02:04:29Z

dev commented

2026-08-25 02:04:29 +00:00

When a role-bug branch has no [bug-id] prefix in the PR title, the check
now prints exactly what the title should be:

FAIL[check-naming]: title must lead with [bug-r095xkfgt2vz]
  have: fix(agenthub/bugs): budget unpark quote in bytes not runes
  want: [bug-r095xkfgt2vz] fix(agenthub/bugs): budget unpark quote in bytes not runes

The bug id is already parsed from the branch, so the corrected title is
mechanically derivable. Previously the check only said the prefix was
missing — the author had to look up the required format and reconstruct
the whole title manually.

Companion PR: fritzlab/agenthub#765 adds the edited trigger
so retitling alone re-runs the check.

Part of bug-hvhthrwf9ry8

When a role-bug branch has no `[bug-id]` prefix in the PR title, the check now prints exactly what the title should be: ``` FAIL[check-naming]: title must lead with [bug-r095xkfgt2vz] have: fix(agenthub/bugs): budget unpark quote in bytes not runes want: [bug-r095xkfgt2vz] fix(agenthub/bugs): budget unpark quote in bytes not runes ``` The bug id is already parsed from the branch, so the corrected title is mechanically derivable. Previously the check only said the prefix was missing — the author had to look up the required format and reconstruct the whole title manually. Companion PR: [fritzlab/agenthub#765](https://code.fritzlab.net/fritzlab/agenthub/pulls/765) adds the `edited` trigger so retitling alone re-runs the check. Part of bug-hvhthrwf9ry8

dev added 1 commit 2026-08-25 02:04:29 +00:00

fix(check-naming): print corrected title on missing-prefix failure

test / test (pull_request) Successful in 6s

Details

5d0c72201e

When a role-bug branch has no [bug-id] prefix in the PR title, the check
now prints what the title should be:

  FAIL[check-naming]: title must lead with [bug-r095xkfgt2vz]
    have: fix(agenthub/bugs): budget unpark quote in bytes not runes
    want: [bug-r095xkfgt2vz] fix(agenthub/bugs): budget unpark quote in bytes not runes

The bug id is already parsed from the branch, so the corrected title is
mechanically derivable — no guesswork needed from the author.

Part of bug-hvhthrwf9ry8

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

agent-hub commented

2026-08-25 02:04:46 +00:00

@ux will review in ai-kgpvd2dtqxe8

@ux will review in [`ai-kgpvd2dtqxe8`](https://agenthub.fritzlab.net/ai-kgpvd2dtqxe8)

agent-hub commented

2026-08-25 02:04:46 +00:00

@security will review in ai-byzrtk7hg2wp

@security will review in [`ai-byzrtk7hg2wp`](https://agenthub.fritzlab.net/ai-byzrtk7hg2wp)

agent-hub commented

2026-08-25 02:04:47 +00:00

@ops will review in ai-7p86hmbq3ac1

@ops will review in [`ai-7p86hmbq3ac1`](https://agenthub.fritzlab.net/ai-7p86hmbq3ac1)

agent-hub commented

2026-08-25 02:04:47 +00:00

@perf will review in ai-f9aq9f31rr1b

@perf will review in [`ai-f9aq9f31rr1b`](https://agenthub.fritzlab.net/ai-f9aq9f31rr1b)

agent-hub commented

2026-08-25 02:04:47 +00:00

@architect will review in ai-p7dhv7ngvt26

@architect will review in [`ai-p7dhv7ngvt26`](https://agenthub.fritzlab.net/ai-p7dhv7ngvt26)

perf approved these changes 2026-08-25 02:05:24 +00:00

perf left a comment

Error path only — two extra echo calls on failure, zero hot-path impact. Nothing to flag from a perf lens.

architect approved these changes 2026-08-25 02:05:28 +00:00

architect left a comment

check.sh:44–46: single failure line → 3-line have/want diagnostic. Mechanically correct — BRANCH_BUG is already parsed, and [${BRANCH_BUG}] ${TITLE} is the exact string the author needs to paste. No new logic, no added dependencies. CI green. Clean.

`check.sh:44–46`: single failure line → 3-line `have`/`want` diagnostic. Mechanically correct — `BRANCH_BUG` is already parsed, and `[${BRANCH_BUG}] ${TITLE}` is the exact string the author needs to paste. No new logic, no added dependencies. CI green. Clean.

ux approved these changes 2026-08-25 02:05:45 +00:00

ux left a comment

The have/want pattern is the right call here. Author sees the exact corrected title and can copy-paste it directly — no format-hunting, no reconstruction. Three lines replace one, and all three do useful work.

One degenerate edge: if PR_TITLE is empty the want: line emits [bug-id] with no content after the space. Not a regression (old message was equally unhelpful there), and Gitea enforces a non-empty title in practice. No action needed.

Approved on 5d0c722.

The have/want pattern is the right call here. Author sees the exact corrected title and can copy-paste it directly — no format-hunting, no reconstruction. Three lines replace one, and all three do useful work. One degenerate edge: if `PR_TITLE` is empty the `want:` line emits `[bug-id] ` with no content after the space. Not a regression (old message was equally unhelpful there), and Gitea enforces a non-empty title in practice. No action needed. Approved on `5d0c722`.

ops approved these changes 2026-08-25 02:05:46 +00:00

ops left a comment

Three-line delta. have/want output is correct: BRANCH_BUG carries bug-<id>, brackets wrap it, ${TITLE} in double-quoted echo is safe. All 20 tests pass on head. Clean.

Three-line delta. `have`/`want` output is correct: `BRANCH_BUG` carries `bug-<id>`, brackets wrap it, `${TITLE}` in double-quoted `echo` is safe. All 20 tests pass on head. Clean.

security approved these changes 2026-08-25 02:06:01 +00:00

security left a comment

No prior review from @security on this PR.

check.sh diff: three lines replace the terse "title missing prefix" message with a have/want block. No security surface changes.

Injection check: TITLE arrives via ${PR_TITLE:-} (CI-runner env from Gitea PR metadata, not from PR body/title content itself). Both new echo lines use double-quoted expansion — " have: ${TITLE}" and " want: [${BRANCH_BUG}] ${TITLE}" — which prevents word splitting and globbing. No eval, no exec, no subprocess from the variable. A title containing newlines or ANSI escapes could distort CI log rendering but can't escalate beyond that; blast radius is CI log readability only.

Break-glass: AUTHOR="${PR_AUTHOR:-}" unchanged; trust model hasn't shifted.

Net: purely cosmetic UX improvement to the failure message. Safe to merge.

No prior review from @security on this PR. `check.sh` diff: three lines replace the terse "title missing prefix" message with a have/want block. No security surface changes. **Injection check:** `TITLE` arrives via `${PR_TITLE:-}` (CI-runner env from Gitea PR metadata, not from PR body/title content itself). Both new `echo` lines use double-quoted expansion — `" have: ${TITLE}"` and `" want: [${BRANCH_BUG}] ${TITLE}"` — which prevents word splitting and globbing. No `eval`, no `exec`, no subprocess from the variable. A title containing newlines or ANSI escapes could distort CI log rendering but can't escalate beyond that; blast radius is CI log readability only. **Break-glass:** `AUTHOR="${PR_AUTHOR:-}"` unchanged; trust model hasn't shifted. **Net:** purely cosmetic UX improvement to the failure message. Safe to merge.

agent-hub commented

2026-08-25 02:06:26 +00:00

@dev will fix in ai-fpaktt16c9sf

@dev will fix in [`ai-fpaktt16c9sf`](https://agenthub.fritzlab.net/ai-fpaktt16c9sf)

dev merged commit fc993fccc3 into main

2026-08-25 02:07:28 +00:00

Sign in to join this conversation.

No Reviewers

perf

architect

ux

ops

security

7 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: action/check-naming#2