architect
1fba1e06b2
test / test (pull_request) Successful in 9s
Authored-By: Codex (GPT-5) <noreply@openai.com>
251 lines
17 KiB
Bash
Executable File
251 lines
17 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Tests for check.sh — exercises valid/invalid branch+title matrices.
|
|
set -euo pipefail
|
|
|
|
SCRIPT="$(cd "$(dirname "$0")/.." && pwd)/check.sh"
|
|
TEST_BIN="$(cd "$(dirname "$0")" && pwd)/bin"
|
|
PASS=0
|
|
FAIL=0
|
|
FIXTURES=$(mktemp -d)
|
|
trap 'rm -rf "${FIXTURES}"' EXIT
|
|
|
|
git -C "${FIXTURES}" init -q
|
|
git -C "${FIXTURES}" config user.name "Test Agent"
|
|
git -C "${FIXTURES}" config user.email "test@noreply.fritzlab.net"
|
|
git -C "${FIXTURES}" commit --allow-empty -q -m "base"
|
|
BASE=$(git -C "${FIXTURES}" rev-parse HEAD)
|
|
git -C "${FIXTURES}" commit --allow-empty -q -m "valid change" -m "Authored-By: Codex (GPT-5) <noreply@openai.com>"
|
|
GOOD_HEAD=$(git -C "${FIXTURES}" rev-parse HEAD)
|
|
|
|
canonical_body() {
|
|
local bug="$1"
|
|
printf '## Tracking\n- Fixes %s — [%s](https://agenthub.fritzlab.net/%s)\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n' "$bug" "$bug" "$bug"
|
|
}
|
|
|
|
check() {
|
|
local desc="$1" want_fail="$2" branch="$3" title="$4" author="$5"
|
|
local bug body
|
|
bug=$(printf '%s\n' "$branch" | sed -nE 's|^[^/]+/(bug-[a-z0-9]+)/.*|\1|p')
|
|
body=$(canonical_body "${bug:-bug-test}")
|
|
local out rc=0
|
|
out=$(cd "${FIXTURES}" && HEAD_BRANCH="$branch" PR_TITLE="$title" PR_AUTHOR="$author" \
|
|
PR_BODY="$body" GITEA_SERVER_URL="https://code.test" GITEA_TOKEN="test-token" \
|
|
GITEA_REPOSITORY="action/check-naming" GITEA_PR_NUMBER=1 PATH="${TEST_BIN}:$PATH" \
|
|
BASE_SHA="$BASE" HEAD_SHA="$GOOD_HEAD" bash "$SCRIPT" 2>&1) || rc=$?
|
|
local got_lines=0
|
|
echo "$out" | grep -qE "^FAIL" && got_lines=1 || true
|
|
if [ "$rc" -eq "$want_fail" ] && [ "$got_lines" -eq "$want_fail" ]; then
|
|
echo "PASS [$desc]"
|
|
PASS=$((PASS + 1))
|
|
else
|
|
echo "FAIL [$desc]: expected exit=$want_fail fail-lines=$want_fail, got exit=$rc fail-lines=$got_lines"
|
|
echo " output: $out"
|
|
FAIL=$((FAIL + 1))
|
|
fi
|
|
}
|
|
|
|
check_contract() {
|
|
local desc="$1" body="$2" base="$3" head="$4" diagnostic="$5"
|
|
local out rc=0
|
|
out=$(cd "${FIXTURES}" && HEAD_BRANCH="architect/bug-x7k2m9/contract" \
|
|
PR_TITLE="[bug-x7k2m9] Enforce contract" PR_AUTHOR="architect" \
|
|
PR_BODY="$body" GITEA_SERVER_URL="https://code.test" GITEA_TOKEN="test-token" \
|
|
GITEA_REPOSITORY="action/check-naming" GITEA_PR_NUMBER=1 PATH="${TEST_BIN}:$PATH" \
|
|
BASE_SHA="$base" HEAD_SHA="$head" bash "$SCRIPT" 2>&1) || rc=$?
|
|
if [ "$rc" -eq 1 ] && printf '%s\n' "$out" | grep -Fq "$diagnostic"; then
|
|
echo "PASS [$desc]"
|
|
PASS=$((PASS + 1))
|
|
else
|
|
echo "FAIL [$desc]: expected exit=1 and diagnostic '$diagnostic', got exit=$rc"
|
|
echo " output: $out"
|
|
FAIL=$((FAIL + 1))
|
|
fi
|
|
}
|
|
|
|
check_contract_pass() {
|
|
local desc="$1" body="$2" base="$3" head="$4"
|
|
local out rc=0
|
|
out=$(cd "${FIXTURES}" && HEAD_BRANCH="architect/bug-x7k2m9/contract" \
|
|
PR_TITLE="[bug-x7k2m9] Enforce contract" PR_AUTHOR="architect" \
|
|
PR_BODY="$body" GITEA_SERVER_URL="https://code.test" GITEA_TOKEN="test-token" \
|
|
GITEA_REPOSITORY="action/check-naming" GITEA_PR_NUMBER=1 PATH="${TEST_BIN}:$PATH" \
|
|
BASE_SHA="$base" HEAD_SHA="$head" bash "$SCRIPT" 2>&1) || rc=$?
|
|
if [ "$rc" -eq 0 ] && printf '%s\n' "$out" | grep -Fq "check-naming: ok"; then
|
|
echo "PASS [$desc]"
|
|
PASS=$((PASS + 1))
|
|
else
|
|
echo "FAIL [$desc]: expected exit=0 and check-naming: ok, got exit=$rc"
|
|
echo " output: $out"
|
|
FAIL=$((FAIL + 1))
|
|
fi
|
|
}
|
|
|
|
check_chore_contract() {
|
|
local desc="$1" body="$2" base="$3" head="$4" diagnostic="$5"
|
|
local out rc=0
|
|
out=$(cd "${FIXTURES}" && HEAD_BRANCH="chore/contract" \
|
|
PR_TITLE="Improve delivery contract" PR_AUTHOR="dev" \
|
|
PR_BODY="$body" GITEA_SERVER_URL="https://code.test" GITEA_TOKEN="test-token" \
|
|
GITEA_REPOSITORY="action/check-naming" GITEA_PR_NUMBER=1 PATH="${TEST_BIN}:$PATH" \
|
|
BASE_SHA="$base" HEAD_SHA="$head" bash "$SCRIPT" 2>&1) || rc=$?
|
|
if [ "$rc" -eq 1 ] && printf '%s\n' "$out" | grep -Fq "$diagnostic"; then
|
|
echo "PASS [$desc]"
|
|
PASS=$((PASS + 1))
|
|
else
|
|
echo "FAIL [$desc]: expected exit=1 and diagnostic '$diagnostic', got exit=$rc"
|
|
echo " output: $out"
|
|
FAIL=$((FAIL + 1))
|
|
fi
|
|
}
|
|
|
|
# break-glass
|
|
check "dfritz exempt — invalid branch" 0 "totally/wrong-branch" "no prefix" "dfritz"
|
|
check "dfritz exempt — mismatch" 0 "dev/bug-abc/thing" "[bug-xyz] Thing" "dfritz"
|
|
|
|
# valid role/bug — all roster handles
|
|
check "dev/bug matching title" 0 "dev/bug-x7k2m9/fix-terminal-resize" "[bug-x7k2m9] Fix terminal resize" "dev"
|
|
check "architect/bug matching title" 0 "architect/bug-abc123/refactor-auth" "[bug-abc123] Refactor auth" "architect"
|
|
check "ops/bug matching title" 0 "ops/bug-zz9/deploy-tweak" "[bug-zz9] Deploy tweak" "ops"
|
|
check "security/bug matching title" 0 "security/bug-s1a2/patch-cve" "[bug-s1a2] Patch CVE" "security"
|
|
check "perf/bug matching title" 0 "perf/bug-p0p0/reduce-latency" "[bug-p0p0] Reduce latency" "perf"
|
|
check "ux/bug matching title" 0 "ux/bug-u1u1/polish-modal" "[bug-u1u1] Polish modal" "ux"
|
|
check "support/bug matching title" 0 "support/bug-sup9/clarify-error" "[bug-sup9] Clarify error" "support"
|
|
|
|
# valid chore form
|
|
check "chore — no title prefix" 0 "chore/bump-deps" "Bump dependency versions" "dev"
|
|
check "chore — plain title" 0 "chore/fix-a-typo" "Fix typo in README" "ops"
|
|
|
|
# fail: role/bug branch but no [bug-id] title prefix
|
|
check "role/bug no title prefix" 1 "dev/bug-x7k2m9/fix-resize" "Fix resize" "dev"
|
|
|
|
# fail: bug-id mismatch between branch and title
|
|
check "bug-id mismatch" 1 "dev/bug-x7k2m9/fix-resize" "[bug-zzzzz1] Fix resize" "dev"
|
|
|
|
# fail: chore branch with [bug-id] title prefix
|
|
check "chore with bug-id title" 1 "chore/bump-deps" "[bug-abc123] Bump deps" "dev"
|
|
check "role/bug Conventional title" 1 "dev/bug-x7k2m9/fix-resize" "[bug-x7k2m9] fix(hub): fix resize" "dev"
|
|
check "role/bug Conventional title gap" 1 "dev/bug-x7k2m9/fix-resize" "[bug-x7k2m9] fix(hub): fix resize" "dev"
|
|
check "chore Conventional title" 1 "chore/bump-deps" "chore(deps): bump deps" "dev"
|
|
check "role/bug breaking title" 1 "dev/bug-x7k2m9/fix-resize" "[bug-x7k2m9] fix!: break resize" "dev"
|
|
|
|
# fail: invalid branch forms
|
|
check "invalid — no role prefix" 1 "feature/foo-bar" "Add feature" "dev"
|
|
check "invalid — missing bug segment" 1 "dev/fix-something" "Fix something" "dev"
|
|
check "invalid — unknown role" 1 "unknown/bug-abc/thing" "[bug-abc] Thing" "dev"
|
|
check "invalid — uppercase bug-id" 1 "dev/bug-ABC123/thing" "[bug-ABC123] Thing" "dev"
|
|
check "invalid — empty kebab" 1 "dev/bug-x7k2m9/" "[bug-x7k2m9] No kebab" "dev"
|
|
check "invalid — no bug prefix on seg" 1 "dev/x7k2m9/fix-resize" "Fix resize" "dev"
|
|
|
|
# Bug-backed PR body contract. These mirror the omissions in agenthub#779.
|
|
BODY=$(canonical_body "bug-x7k2m9")
|
|
check_contract "raw Fixes only rejects missing link and attribution" \
|
|
$'## Tracking\n- Fixes bug-x7k2m9' "$BASE" "$GOOD_HEAD" "must link https://agenthub.fritzlab.net/bug-x7k2m9"
|
|
check_contract "tracking rejects linked Fixes without literal token" \
|
|
$'## Tracking\n- Fixes [bug-x7k2m9](https://agenthub.fritzlab.net/bug-x7k2m9)\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD" "must contain the literal token 'Fixes bug-x7k2m9'"
|
|
check_contract "tracking rejects wrong Bug URL" \
|
|
$'## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-other\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD" "must link https://agenthub.fritzlab.net/bug-x7k2m9"
|
|
check_contract "attribution must be in its own section" \
|
|
$'## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD" "## Attribution must contain"
|
|
check_contract "hidden provenance does not satisfy the visible contract" \
|
|
$'<!--\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "comment removal cannot synthesize section headings" \
|
|
$'<!-- hidden -->## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n<!-- hidden -->## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "four-space indented backticks do not expose comments" \
|
|
$' ````\n<!--\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "unequal backtick runs do not expose comments" \
|
|
$'`<!--``\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "invalid backtick fence info does not expose comments" \
|
|
$'```html`oops\n<!--\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "invalid fence closer does not expose comments" \
|
|
$'```html\n```oops\n```\n<!--\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "fences inside comments do not expose provenance" \
|
|
$'<!--\n```html\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "escaped backticks do not hide a comment opener" \
|
|
$'\\`<!--\\`\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n-->' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "fenced provenance does not satisfy the visible contract" \
|
|
$'```\n```oops\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "indented fence closer does not expose provenance" \
|
|
$'```\n ```\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n```' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract_pass "fenced code examples remain available" \
|
|
$'```html\n<script>example only</script>\n```\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD"
|
|
check_contract "details cannot collapse provenance" \
|
|
$'<details><summary>Release notes</summary>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</details>' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract_pass "open details preserve visible provenance" \
|
|
$'<details open><summary>Release notes</summary>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</details>' \
|
|
"$BASE" "$GOOD_HEAD"
|
|
check_contract "open details inside collapsed details remain hidden" \
|
|
$'<details><summary>Release notes</summary>\n<details open><summary>Visible only after expansion</summary>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</details>\n</details>' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "open text in another details attribute remains collapsed" \
|
|
$'<details title="x open y"><summary>Release notes</summary>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</details>' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "video fallback cannot hide provenance" \
|
|
$'<video controls>\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</video>' \
|
|
"$BASE" "$GOOD_HEAD" "move ## Tracking and ## Attribution outside collapsed <details> or <video>/<audio> fallback content"
|
|
check_contract "audio fallback cannot hide provenance" \
|
|
$'<audio controls>\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</audio>' \
|
|
"$BASE" "$GOOD_HEAD" "move ## Tracking and ## Attribution outside collapsed <details> or <video>/<audio> fallback content"
|
|
check_contract_pass "unrelated collapsed details remain available" \
|
|
$'<details><summary>Logs</summary>\n\nSupporting output\n</details>\n\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>' \
|
|
"$BASE" "$GOOD_HEAD"
|
|
check_contract "script cannot suppress provenance" \
|
|
$'<script>\n## Tracking\n- Fixes bug-x7k2m9 — https://agenthub.fritzlab.net/bug-x7k2m9\n\n## Attribution\n- Authored-By: Codex (GPT-5) <noreply@openai.com>\n</script>' \
|
|
"$BASE" "$GOOD_HEAD" "PR body must contain a non-empty ## Tracking section"
|
|
check_contract "stalled renderer fails closed at the curl timeout" \
|
|
"$(canonical_body bug-x7k2m9)"$'\n[[stall-renderer]]' \
|
|
"$BASE" "$GOOD_HEAD" "Gitea could not render the PR body"
|
|
|
|
LARGE_BODY="${FIXTURES}/large-pr-body"
|
|
awk 'BEGIN { for (i=0; i<150000; i++) printf "x"; print "" }' > "${LARGE_BODY}"
|
|
canonical_body bug-x7k2m9 >> "${LARGE_BODY}"
|
|
large_out=""
|
|
large_rc=0
|
|
large_out=$(cd "${FIXTURES}" && HEAD_BRANCH="architect/bug-x7k2m9/contract" \
|
|
PR_TITLE="[bug-x7k2m9] Enforce contract" PR_AUTHOR="architect" \
|
|
TEST_PR_BODY_FILE="${LARGE_BODY}" GITEA_SERVER_URL="https://code.test" GITEA_TOKEN="test-token" \
|
|
GITEA_REPOSITORY="action/check-naming" GITEA_PR_NUMBER=1 PATH="${TEST_BIN}:$PATH" \
|
|
BASE_SHA="$BASE" HEAD_SHA="$GOOD_HEAD" bash "$SCRIPT" 2>&1) || large_rc=$?
|
|
if [ "${large_rc}" -eq 0 ] && printf '%s\n' "${large_out}" | grep -Fq "check-naming: ok"; then
|
|
echo "PASS [large PR body loads without environment transport]"
|
|
PASS=$((PASS + 1))
|
|
else
|
|
echo "FAIL [large PR body loads without environment transport]: expected exit=0 and check-naming: ok, got exit=${large_rc}"
|
|
echo " output: ${large_out}"
|
|
FAIL=$((FAIL + 1))
|
|
fi
|
|
|
|
git -C "${FIXTURES}" commit --allow-empty -q -m "unwatermarked change"
|
|
BAD_HEAD=$(git -C "${FIXTURES}" rev-parse HEAD)
|
|
check_contract "agenthub 779 commits reject missing watermark" "$BODY" "$GOOD_HEAD" "$BAD_HEAD" "must end with an Authored-By"
|
|
check_chore_contract "chore requires PR attribution" "" "$BASE" "$GOOD_HEAD" "## Attribution must contain"
|
|
check_chore_contract "chore commits require watermark" "$(canonical_body bug-unused)" "$GOOD_HEAD" "$BAD_HEAD" "must end with an Authored-By"
|
|
|
|
git -C "${FIXTURES}" commit --allow-empty -q -m $'misplaced trailer\nAuthored-By: Codex (GPT-5) <noreply@openai.com>'
|
|
MISPLACED_HEAD=$(git -C "${FIXTURES}" rev-parse HEAD)
|
|
check_contract "commit watermark requires blank separator" "$BODY" "$BAD_HEAD" "$MISPLACED_HEAD" "must end with an Authored-By"
|
|
|
|
git -C "${FIXTURES}" commit --allow-empty -q -m "trailer not final" -m $'Authored-By: Codex (GPT-5) <noreply@openai.com>\nextra text'
|
|
NONFINAL_HEAD=$(git -C "${FIXTURES}" rev-parse HEAD)
|
|
check_contract "commit watermark must be final trailer" "$BODY" "$MISPLACED_HEAD" "$NONFINAL_HEAD" "must end with an Authored-By"
|
|
check_contract "missing commit range rejects" "$BODY" "$GOOD_HEAD" "$GOOD_HEAD" "contains no PR commits"
|
|
check_contract "invalid SHA rejects before git" "$BODY" "not-a-sha" "$GOOD_HEAD" "lowercase hexadecimal"
|
|
|
|
echo ""
|
|
echo "Results: ${PASS} passed, ${FAIL} failed"
|
|
[ "${FAIL}" -eq 0 ]
|